Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(diff): compare config in both ways #60

Merged
merged 1 commit into from
Apr 21, 2016
Merged

feat(diff): compare config in both ways #60

merged 1 commit into from
Apr 21, 2016

Conversation

ta2edchimp
Copy link
Collaborator

Implements the two way diffing on

eslint-diff-rules config1 config2

This PR still includes its predecessor's commit — so I guess it (again) should be rebased after #58 got merged (why does this not get resolved automatically??) ...

@codecov-io
Copy link

Current coverage is 100.00%

Merging #60 into master will not affect coverage as of 291b23a

@@            master     #60   diff @@
======================================
  Files            7       7       
  Stmts          137     154    +17
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            137     154    +17
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of 291b23a

Powered by Codecov. Updated on successful CI builds.

@sarbbottam
Copy link
Owner

LGTM, I will leave it to you to merge the PR, I guess this one is built on top of the other.

@ta2edchimp
Copy link
Collaborator Author

Yep. I'll merge #58 tomorrow, rebase and merge this one afterwards and build upon those with the original PR #50.

Now off to 😴 soon

@ta2edchimp
Copy link
Collaborator Author

This PR still includes its predecessor's commit — so I guess it (again) should be rebased after #58 got merged (why does this not get resolved automatically??) ...

I guess I have to explicitly cherry-pick the commits into branches for future PRs of this kind.

@ta2edchimp
Copy link
Collaborator Author

For the record, I tweaked bin/diff's tests a bit to reflect the two way diffing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants