Properly handle tabs and newlines in node values #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strictly assert the structure of the node
KSP removes these automatically, so we want to avoid that by constructing the Value ourselves
Use AssertValue method Use AssertEmpty rather than asserting count zero
KSP removes these in AddValue, we can circumvent that by constructing the Value ourselves
new AddValueSafe method to handle this use safe ShallowCopyFrom rather than ConfigNode's CopyTo as recursion is not necessary and it handles escaped characters correctly
Explicitly escape \n and \t which the localizer unescapes when game database is initially loaded
|
run test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KSP strips them out in
ConfigNode.AddValue(string, string), meaning the cache didn't break but the newlines would get removed from strings.This fixes some that in some
ConfigNodemodifying code, and makes sure that the cache also handles it properlyResolves #84