plugins/nd: Fix building with CFLAGS=-fno-common #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! I’ll just be nitpicky on the commit message: although I don’t always succeed, I try to describe the actual issue in the summary for this kind of fixes. Also, I use "nd:" as the prefix (IOW, just the plugin name), "plugins:" is for commits that affects many plugins at once for a generic change. |
With the GCC flag -fno-common, which is enabled by default in GCC >=10, the linker fails with messages like these: ld: plugins/nd/1b87e75@@nd@sha/src_notification.c.o:(.bss+0x0): multiple definition of `eventd_nd_backends_names'; plugins/nd/1b87e75@@nd@sha/src_nd.c.o:(.data.rel.local+0x20): first defined here ld: plugins/nd/1b87e75@@nd@sha/src_backends.c.o:(.bss+0x0): multiple definition of `eventd_nd_backends_names'; plugins/nd/1b87e75@@nd@sha/src_nd.c.o:(.data.rel.local+0x20): first defined here collect2: error: ld returned 1 exit status Fix this by declaring eventd_nd_backends_names as extern. Signed-off-by: Jeroen Roovers <jer@gentoo.org>
|
I adjusted the commit message. |
|
Perfect! Thanks again :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the GCC -fno-common flag, enabled by default in GCC >=10, the
linker fails with messages like these:
ld: plugins/nd/1b87e75@@nd@sha/src_notification.c.o:(.bss+0x0): multiple
definition of
eventd_nd_backends_names'; plugins/nd/1b87e75@@nd@sha/src_nd.c.o:(.data.rel.local+0x20): first defined here ld: plugins/nd/1b87e75@@nd@sha/src_backends.c.o:(.bss+0x0): multiple definition ofeventd_nd_backends_names';plugins/nd/1b87e75@@nd@sha/src_nd.c.o:(.data.rel.local+0x20): first
defined here
collect2: error: ld returned 1 exit status
Fix this by declaring eventd_nd_backends_names as extern.
Signed-off-by: Jeroen Roovers jer@gentoo.org