Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - $this->backupSuffix #18

Closed
JeffGepiga opened this issue May 24, 2022 · 2 comments
Closed

Bug - $this->backupSuffix #18

JeffGepiga opened this issue May 24, 2022 · 2 comments

Comments

@JeffGepiga
Copy link
Contributor

JeffGepiga commented May 24, 2022

backupSuffix is stored in config, config file only get refresh if you optimize cache, so if you did not optimize laravel time to time, it will get the backupSuffix the last optimized date, so new backup will automatically delete the previous backup since it has the same name or suffix.

I run the backupmanage:create on cron every week and it only backup single file which is the latest.

My suggestion would be, change the backup_file_date_suffix in config file to only date format not the date() itself and in
// backupmanage.php config

'backup_file_date_suffix' => 'M-d-Y',

//BackupManager class

$this->backupSuffix = date(strtolower(config('backupmanager.backups.backup_file_date_suffix')));

Thank you.

@sarfraznawaz2005
Copy link
Owner

Please PR.

@JeffGepiga
Copy link
Contributor Author

Please check

#19 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants