Skip to content

Commit

Permalink
Rename result classes
Browse files Browse the repository at this point in the history
  • Loading branch information
yalef committed Nov 24, 2023
1 parent 3b72709 commit 6f94f90
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions import_export_extensions/resources.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class TaskState(Enum):
PARSING = _("Parsing")


class SkippedErrorsRowResult(results.RowResult):
class SkippedRow(results.RowResult):
"""Custom row result class with ability to store skipped errors in row."""
def __init__(self):
self.non_field_skipped_errors: list[Error] = []
Expand All @@ -64,7 +64,7 @@ def skipped_errors_count(self) -> int:
)


class SkippedErrorsResult(results.Result):
class ResultWithSkippedRows(results.Result):
"""Custom result class with ability to store info about skipped rows."""

@property
Expand All @@ -75,7 +75,7 @@ def has_skipped_rows(self) -> bool:
return False

@property
def skipped_rows(self) -> list[SkippedErrorsRowResult]:
def skipped_rows(self) -> list[SkippedRow]:
"""Return all rows with skipped errors."""
return list(
filter(lambda row: row.has_skipped_errors, self.rows),
Expand Down Expand Up @@ -181,7 +181,7 @@ def import_row(
`field_skipped_errors` or `non_field_skipped_errors`.
"""
imported_row: SkippedErrorsRowResult = super().import_row(
imported_row: SkippedRow = super().import_row(
row=row,
instance_loader=instance_loader,
using_transactions=using_transactions,
Expand Down Expand Up @@ -221,12 +221,12 @@ def import_row(
@classmethod
def get_row_result_class(self):
"""Return custom row result class."""
return SkippedErrorsRowResult
return SkippedRow

@classmethod
def get_result_class(self):
"""Geti custom result class."""
return SkippedErrorsResult
return ResultWithSkippedRows

def export(
self,
Expand Down

0 comments on commit 6f94f90

Please sign in to comment.