Refactor tests

saritasa-nest · Nov 30, 2023 · 8e12ea0 · 8e12ea0
1 parent c09957d
commit 8e12ea0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/tests/test_api/test_import.py b/tests/test_api/test_import.py
@@ -40,6 +40,7 @@ def test_import_api_detail(
             kwargs={"pk": artist_import_job.id},
         ),
     )
+    assert response.status_code == status.HTTP_200_OK, response.data
     assert response.data["import_status"] == ImportJob.ImportStatus.PARSED
 
     artist_import_job.refresh_from_db()
@@ -51,6 +52,7 @@ def test_import_api_detail(
             kwargs={"pk": artist_import_job.id},
         ),
     )
+    assert response.status_code == status.HTTP_200_OK, response.data
     assert response.data["import_finished"]
 
 
@@ -73,6 +75,7 @@ def test_force_import_api_detail(
             kwargs={"pk": force_import_artist_job.id},
         ),
     )
+    assert response.status_code == status.HTTP_200_OK, response.data
     assert response.data["import_status"] == ImportJob.ImportStatus.PARSED
 
     force_import_artist_job.refresh_from_db()
@@ -84,6 +87,7 @@ def test_force_import_api_detail(
             kwargs={"pk": force_import_artist_job.id},
         ),
     )
+    assert response.status_code == status.HTTP_200_OK, response.data
     assert response.data["import_finished"]
 
     force_import_artist_job.refresh_from_db()

diff --git a/tests/test_models/test_import/test_import_data.py b/tests/test_models/test_import/test_import_data.py
@@ -123,8 +123,10 @@ def test_import_data_skip_parse_step(
     import_job.refresh_from_db()
 
     assert import_job.import_status == expected_status
-    if is_instance_created:
-        assert Artist.objects.filter(name=new_artist.name).exists()
+    assert (
+        Artist.objects.filter(name=new_artist.name).exists()
+        == is_instance_created
+    )
 
 
 def test_force_import_create_correct_rows(
@@ -139,5 +141,5 @@ def test_force_import_create_correct_rows(
     )
     import_job.import_data()
     import_job.refresh_from_db()
-    assert import_job.ImportStatus.IMPORTED
+    assert import_job.import_status == import_job.ImportStatus.IMPORTED
     assert Artist.objects.filter(name=new_artist.name).exists()