Improve Django Admin integration with original package #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `DjagnoObjectActions` package is not neccesary here so decided to remove it and use built-in django admin actions * Rename `filter_class` to `filterset_class`
* Remove django_object_actions from test app config * Revert to psycopg2-binary
NikAzanov
force-pushed
the
improve-original-package-integration
branch
from
4a46a2e
to
4d22194
Compare
ron8mcr
requested changes
Sep 1, 2023
import_export_extensions/admin/model_admins/export_job_admin.py
Outdated
Show resolved
Hide resolved
yalef
reviewed
Sep 8, 2023
import_export_extensions/admin/model_admins/export_job_admin.py
Outdated
Show resolved
Hide resolved
import_export_extensions/admin/model_admins/export_job_admin.py
Outdated
Show resolved
Hide resolved
import_export_extensions/admin/model_admins/import_job_admin.py
Outdated
Show resolved
Hide resolved
import_export_extensions/admin/model_admins/import_job_admin.py
Outdated
Show resolved
Hide resolved
| @@ -43,14 +43,15 @@ To install `django-import-export-extensions`, run this command in your terminal: | |||
|
|
|||
| $ pip install django-import-export-extensions | |||
|
|
|||
| Add `import_export_extensions` to INSTALLED_APPS | |||
| Add `import_export` and `import_export_extensions` to INSTALLED_APPS | |||
There was a problem hiding this comment.
As I mention in other PR's I think we should use double quotes instead of single ones
NikAzanov
force-pushed
the
improve-original-package-integration
branch
from
c1496b7
to
2711f57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, all admin models and admin templates were rewritten from the original package and didn't use inheritance. In this PR I tried to reuse the
django-import-exportcode by inheritance to reduce the amount of code and make it easier to make changes.In this PR:
DjangoObjectActionsand implement default django admin action instead (Maybe later we can extend this)mixins.BaseExportMixin,mixins.BaseImportMixinandadmin.ImportExportMixinBasefrom original package for celery admin mixinsadmin/import_export/templates instead of copies inadmin/import_export_ext/filter_classtofilterset_classcancel_jobaction for exporting