Make possible to pass resource kwargs in view sets #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyGreenwell94
requested changes
Sep 6, 2023
There was a problem hiding this comment.
If I get it correctly, this allows us to pass some values from the API. This is not exactly the case with #13 . I don't think it's useful to pass them from the user, but probably we can implement some sort of method like get_resourse_kwargs on the ViewSet level, to pass kwargs like a user, or some user-related data to a resource.
NikAzanov
force-pushed
the
improve-api-views
branch
from
a94faf2
to
25b113a
Compare
NikAzanov
changed the title
NikAzanov
force-pushed
the
extend-documentation
branch
from
ef69ade
to
bf00dbe
Compare
It makes possible to pass some values in resource class from viewset. Also simplify ImportJobViewSet not to use filterset class
NikAzanov
force-pushed
the
improve-api-views
branch
from
25b113a
to
e508d66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add get_resource_kwargs method to viewsets
Simplify
ImportJobViewSetnot to use filterset classCloses #13