Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actualize docker compose #24

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Actualize docker compose #24

merged 2 commits into from
Nov 20, 2023

Conversation

yalef
Copy link
Contributor

@yalef yalef commented Nov 15, 2023

Since docker compose v2 has been released, we should change usage of docker compose in project.
https://docs.docker.com/compose/migrate/

  • Change docker-compose to docker compose
  • Update docker-compose.yaml

Other changes:

@yalef yalef marked this pull request as ready for review November 16, 2023 06:35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding saritasa-invocations?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but there're some cons:

  • configuration become a bit complicated due not typical location of django app(tests).
  • currently saritasa-invocations doesn't provide settings for location of manage.py file, so django invokes can be used only after cd in tests/ dir.
  • we don't have that much invokes in this package so saritasa-invocations might be overkill.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think we can add manage.py location as config with default manage.py
  • Other than that everything is same or can be replaced, the idea is to lower amount of code. For example pomcorn uses even less https://github.com/saritasa-nest/pomcorn/blob/main/tasks.py, but it still lower amount of code in repo

provision/docker.py Outdated Show resolved Hide resolved
@yalef yalef merged commit a3aa8ce into main Nov 20, 2023
27 checks passed
@yalef yalef deleted the feature/actualize-docker-compose branch December 21, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants