Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add force-import feature #25

Merged
merged 30 commits into from
Dec 1, 2023
Merged

Add force-import feature #25

merged 30 commits into from
Dec 1, 2023

Conversation

yalef
Copy link
Contributor

@yalef yalef commented Nov 21, 2023 •
edited
Loading

Add force-import functionality to API and admin.

Add force_import field to /import-job/start endpoint
Add skip_parse_step field to /import-job/start endpoint
Add force_import checkbox to admin

Add custom result and row result classes to store information about skipped errors.

image

image

image

@yalef yalef changed the title Feature/force import Add force-import feature Nov 21, 2023
@yalef yalef marked this pull request as ready for review November 22, 2023 10:37
NikAzanov
NikAzanov requested changes Nov 26, 2023
View reviewed changes
Copy link
Contributor

@NikAzanov NikAzanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add docs for this feature

Also it would be nice to see how it looks in PR (in attached images)

import_export_extensions/resources.py Outdated Show resolved Hide resolved
import_export_extensions/resources.py Outdated Show resolved Hide resolved
@yalef
Copy link
Contributor Author

yalef commented Nov 27, 2023

Also it would be nice to see how it looks in PR (in attached images)

It attached actually:smile:

@yalef yalef requested a review from NikAzanov November 29, 2023 09:27
OttoAndrey
OttoAndrey reviewed Nov 30, 2023
View reviewed changes
tests/test_api/test_import.py Outdated Show resolved Hide resolved
tests/test_models/test_import/test_import_data.py Outdated Show resolved Hide resolved
@yalef
Copy link
Contributor Author

yalef commented Nov 30, 2023 •
edited
Loading

After discussion with @OttoAndrey I've also added skip_parse_step field to /start enpoint to be able to skip parse-confirm step in api.
FYI @TheSuperiorStanislav @NikAzanov

NikAzanov
NikAzanov approved these changes Dec 1, 2023
View reviewed changes
HISTORY.rst Show resolved Hide resolved
docs/extensions.rst Outdated Show resolved Hide resolved
@yalef yalef merged commit c21f46c into main Dec 1, 2023
27 checks passed
@yalef yalef deleted the feature/force-import branch December 21, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OttoAndrey OttoAndrey OttoAndrey approved these changes

@TheSuperiorStanislav TheSuperiorStanislav TheSuperiorStanislav approved these changes

@NikAzanov NikAzanov NikAzanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yalef @OttoAndrey @TheSuperiorStanislav @NikAzanov