-
Notifications
You must be signed in to change notification settings - Fork 45
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[lang] No "unused function" warning when a function is inoked with it…
…s parameters' default values. close #895 Signed-off-by: Stéphane Galland <galland@arakhne.org>
- Loading branch information
1 parent
53f9864
commit 342b3f6
Showing
5 changed files
with
187 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
127 changes: 127 additions & 0 deletions
127
tests/io.sarl.lang.tests/src/test/java/io/sarl/lang/tests/bugs/to00999/Bug895.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| /* | ||
| * Copyright (C) 2014-2018 the original authors or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.sarl.lang.tests.bugs.to00999; | ||
|
|
||
| import com.google.inject.Inject; | ||
| import org.eclipse.xtend.core.validation.IssueCodes; | ||
| import org.eclipse.xtext.xbase.testing.CompilationTestHelper; | ||
| import org.junit.Test; | ||
|
|
||
| import io.sarl.lang.SARLVersion; | ||
| import io.sarl.lang.sarl.SarlPackage; | ||
| import io.sarl.lang.sarl.SarlScript; | ||
| import io.sarl.tests.api.AbstractSarlTest; | ||
| import io.sarl.tests.api.AbstractSarlTest.Validator; | ||
|
|
||
| /** Testing class for issue: Invalid "function not used" warning for functions with default valued parameter. | ||
| * | ||
| * <p>https://github.com/sarl/sarl/issues/895 | ||
| * | ||
| * @author $Author: sgalland$ | ||
| * @author $Author: alombard$ | ||
| * @version $Name$ $Revision$ $Date$ | ||
| * @mavengroupid $GroupId$ | ||
| * @mavenartifactid $ArtifactId$ | ||
| * @see "https://github.com/sarl/sarl/issues/895" | ||
| */ | ||
| @SuppressWarnings("all") | ||
| public class Bug895 extends AbstractSarlTest { | ||
|
|
||
| private static final String CALL_WITH_DEFAULT_VALUE = multilineString( | ||
| "package io.sarl.lang.tests.bug895", | ||
| "class X {", | ||
| " private def f1(param : int = 0) : void {", | ||
| " }", | ||
| " def f {", | ||
| " f1", | ||
| " }", | ||
| "}"); | ||
|
|
||
|
|
||
| @Test | ||
| public void callWithDefaultValue() throws Exception { | ||
| SarlScript mas = file(CALL_WITH_DEFAULT_VALUE); | ||
| final Validator validator = validate(mas); | ||
| validator.assertNoWarnings( | ||
| SarlPackage.eINSTANCE.getSarlAction(), | ||
| IssueCodes.UNUSED_PRIVATE_MEMBER); | ||
| } | ||
|
|
||
| private static final String CALL_WITH_EXPLICIT_VALUE = multilineString( | ||
| "package io.sarl.lang.tests.bug895", | ||
| "class X {", | ||
| " private def f1(param : int = 0) : void {", | ||
| " }", | ||
| " def f {", | ||
| " f1(4)", | ||
| " }", | ||
| "}"); | ||
|
|
||
|
|
||
| @Test | ||
| public void callWithExplicitValue() throws Exception { | ||
| SarlScript mas = file(CALL_WITH_EXPLICIT_VALUE); | ||
| final Validator validator = validate(mas); | ||
| validator.assertNoWarnings( | ||
| SarlPackage.eINSTANCE.getSarlAction(), | ||
| IssueCodes.UNUSED_PRIVATE_MEMBER); | ||
| } | ||
|
|
||
| private static final String CALL_WITH_CLASSIC_ARGUMENT = multilineString( | ||
| "package io.sarl.lang.tests.bug895", | ||
| "class X {", | ||
| " private def f1(param : int) : void {", | ||
| " }", | ||
| " def f {", | ||
| " f1(4)", | ||
| " }", | ||
| "}"); | ||
|
|
||
|
|
||
| @Test | ||
| public void callWithClassicArgument() throws Exception { | ||
| SarlScript mas = file(CALL_WITH_CLASSIC_ARGUMENT); | ||
| final Validator validator = validate(mas); | ||
| validator.assertNoWarnings( | ||
| SarlPackage.eINSTANCE.getSarlAction(), | ||
| IssueCodes.UNUSED_PRIVATE_MEMBER); | ||
| } | ||
|
|
||
| private static final String NO_CALL_WITH_CLASSIC_ARGUMENT = multilineString( | ||
| "package io.sarl.lang.tests.bug895", | ||
| "class X {", | ||
| " private def f1(param : int) : void {", | ||
| " }", | ||
| " private def f2 : void {", | ||
| " }", | ||
| " def f {", | ||
| " f2", | ||
| " }", | ||
| "}"); | ||
|
|
||
|
|
||
| @Test | ||
| public void noCallWithClassicArgument() throws Exception { | ||
| SarlScript mas = file(NO_CALL_WITH_CLASSIC_ARGUMENT); | ||
| final Validator validator = validate(mas); | ||
| validator.assertWarning( | ||
| SarlPackage.eINSTANCE.getSarlAction(), | ||
| IssueCodes.UNUSED_PRIVATE_MEMBER, | ||
| "f1(int)"); | ||
| } | ||
|
|
||
| } |