Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete wrong faq post regarding working with Git #472

Closed
chrismotian opened this issue Mar 14, 2019 · 1 comment
Closed

Delete wrong faq post regarding working with Git #472

chrismotian opened this issue Mar 14, 2019 · 1 comment
Labels
Area: Documentation Issue affecting the Saros documentation

Comments

@chrismotian
Copy link

On http://www.saros-project.org/faq you can find a help text regarding the usage of Git and Saros together. The post mentions a Safe and Risky Layout. After a short manual test, I couldn't restore the problems with the Risky Layout. We should delete the wrong post, specify it more (maybe my test isn't handling everything) or keep in mind to not bring that post to the new website

Testcase: Add to Session a Project with Git

System under discussion: Eclipse with Saros Plugin

First Actor: Alice
Second Actor: Bob

Goal: Alice and Bob are in a shared session, same files on each side, both are at the same branch and commit

Requirements: Alice and Bob using Eclipse and are connected to Saros, Alice has an open project which uses Git, Alice's HEAD checkout at master, No files on Bob's side

Test: Alice shares every file (including the .git directory). Right and wrong folder structure

Expected Behaviour:
Right folder structure: .git directory isn't sent through Saros. Bob isn't using Git
Wrong folder structure: Saros send all the data. All goals reached.

After Test:
Right folder structure: Saros create a new project on Bob's side. Alice and Bob are in a shared session, same files on each side but .git the directory isn't sent through Saros. Bob isn't using Git. .gitignore file is sent through Saros
Wrong folder structure: Same as above

@chrismotian chrismotian added the Area: Documentation Issue affecting the Saros documentation label Mar 14, 2019
@chrismotian
Copy link
Author

chrismotian commented Mar 26, 2019

The testcase above isn't reproducible. The Risky Layout is indeed risky. I've tried to reproduce it and realize that Bob received the .git directory.

I tested also the case when Bob had worked on the project before and because of that choose working with existing project in the invitation process. Same here. Bob's .git directory becomes updated by Alice's and this is risky, too.

My suggestions:

  • Create an stf test because it seems like the fact that I can't reproduce the testcase is a side effect of some changes in between this comment and the one 12 days ago and we need more control about things like that.
  • Keep the Risky and Safe Layout-Post on the FAQ side and
  • bring it to the new website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Documentation Issue affecting the Saros documentation
Projects
None yet
Development

No branches or pull requests

1 participant