Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/167 drop the pickles #174

Merged
merged 12 commits into from
Apr 15, 2022
Merged

Conversation

essweine
Copy link
Contributor

@essweine essweine commented Apr 1, 2022

This PR adds a completely new serializer that

  • does not use pickle
  • does not serialize objects multiple times
  • generates readable output (to the extent that such a large json object is readable)
  • allows for custom handling of specs and data

@essweine essweine requested a review from danfunk April 1, 2022 23:01
essweine and others added 7 commits April 7, 2022 13:24
…ue, and check that value before deserializing, to allow for easier migrations.

Add deprecation warnings to anything that sub-classes the old serializer, or uses it to serialize new json.
Create a set of tests specifically for new serializer, and add a test to assure version setting works.
…oduces a workflow that cannot be serialized with the new serializer.
@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

94.9% 94.9% Coverage
0.0% 0.0% Duplication

@danfunk danfunk merged commit 6fcb48a into master Apr 15, 2022
@danfunk danfunk deleted the enhancement/167-drop-the-pickles branch April 15, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants