Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Use self.spec_class instead of direct use of base object #186

Merged
merged 1 commit into from Jun 15, 2022
Merged

[FIX] Use self.spec_class instead of direct use of base object #186

merged 1 commit into from Jun 15, 2022

Conversation

Giulios74
Copy link
Contributor

Use self.spec_class instead of direct use of base object, so we can extend event like other task specs

@danfunk
Copy link
Collaborator

danfunk commented Jun 15, 2022

Surgical, precise, clean. Thank you @Giulios74.

@danfunk danfunk merged commit 535f0c6 into sartography:main Jun 15, 2022
@Giulios74 Giulios74 deleted the fix/events_spec branch June 30, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burnettk burnettk burnettk approved these changes

@danfunk danfunk danfunk approved these changes

@essweine essweine essweine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Giulios74 @danfunk @burnettk @essweine