Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bpmn references from dict.py and json.py #236

Merged
merged 9 commits into from Sep 29, 2022
Merged

Remove bpmn references from dict.py and json.py #236

merged 9 commits into from Sep 29, 2022

Conversation

jbirddog
Copy link
Contributor

Diff is on the larger side but I tried to change as little logic as possible. The main changes here are splitting DictionarySerializer and JSONSerializer in "core" and moving the bpmn specific parts to BPMNDictionarySerializer in bpmn/serializer/dict.pyandBPMNJSONSerializerinbpmn/serializer/json.py. The bpmn specific serializers are subclasses of the core serializers and only override when needed. I believe the split is correct but if anything looks off please let me know. For JSONSerializer` I also moved top level functions to class methods to make things easier on the subclass.

If I grepped correctly this combined with the other bpmn import related prs purge core of all bpmn/dmn/camunda references.

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

57.7% 57.7% Coverage
0.0% 0.0% Duplication

@danfunk danfunk merged commit 2313fed into main Sep 29, 2022
@jbirddog jbirddog deleted the dict_json branch October 4, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants