Remove bpmn references from dict.py and json.py #236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff is on the larger side but I tried to change as little logic as possible. The main changes here are splitting
DictionarySerializer
andJSONSerializer
in "core" and moving the bpmn specific parts toBPMNDictionarySerializer in
bpmn/serializer/dict.pyand
BPMNJSONSerializerin
bpmn/serializer/json.py. The bpmn specific serializers are subclasses of the core serializers and only override when needed. I believe the split is correct but if anything looks off please let me know. For
JSONSerializer` I also moved top level functions to class methods to make things easier on the subclass.If I grepped correctly this combined with the other bpmn import related prs purge core of all bpmn/dmn/camunda references.