Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not install importlib-metadata if greater than python 3.7 w/ burnettk #253

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

jasquat
Copy link
Contributor

@jasquat jasquat commented Oct 18, 2022

importlib-metadata breaks python 3.10 at least so avoid installing it if we don't need to.

Copy link
Contributor

@burnettk burnettk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we install importlib-metadata 4.2 in python 3.10, it breaks flask-bpmn.

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jasquat jasquat merged commit b9e3dd8 into main Oct 19, 2022
@jasquat jasquat deleted the feature/avoid_importlib_for_python_3.8_up branch October 19, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants