Feature/standardize task execution #307

essweine · 2023-03-27T21:05:18Z

This PR creates a new _run method on task specs that runs the tasks. This method should return True if execution was successful, False if unsuccessful (success and failure are still currently conflated in the COMPLETED task state, but in the future we can differentiate them) or None if the task is not complete, in which case the state will be changed to WAITING

This will allow a custom script engine to execute scripts or service tasks to immediately return None while the task executes without holding up the rest of the workflow. The behavior of the default script engine executes scripts synchronously and returns True on successful completion. This preserves the current behavior.

The old _on_ready_hook method can be used to execute code when the task becomes READY but before it is run; this makes on_ready_before redundant so I've removed it.

I've also changed the prediction model so that (1) we no longer always re-predict definite tasks and (2) the states actually change when sync_children is called. Definite tasks can still be re-predicted by providing an optional mask to _predict.

…ents)

github-advanced-security · 2023-03-27T21:05:21Z

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.