Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/depth calc and task dict fixes #355

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

essweine
Copy link
Contributor

This PR

  • ensure that inaccessible tasks are removed from the workflow's task dict
  • correctly calculates the depth of a node during iteration

@@ -0,0 +1,245 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wanted to make sure you intended to include training workflow as a part of this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that was a mistake. Removed.

task.run()
return updated

class DepthFirstTest(IterationTest):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you writing a computer science textbook here or what? :)

@essweine essweine force-pushed the bugfix/depth-calc-and-task-dict-fixes branch from 561f129 to 7c5072e Compare September 28, 2023 17:06
@essweine essweine merged commit 92a7fdc into main Sep 28, 2023
4 checks passed
@essweine essweine deleted the bugfix/depth-calc-and-task-dict-fixes branch September 28, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants