added server default to new future_task column so default is actually…

… added to the table schema w/ burnettk
sartography · Feb 6, 2024 · af1eb6f · af1eb6f
1 parent 5d081ec
commit af1eb6f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/...kend/migrations/versions/acf20342181e_.py → ...kend/migrations/versions/29b261f5edf4_.py b/...kend/migrations/versions/acf20342181e_.py → ...kend/migrations/versions/29b261f5edf4_.py
@@ -1,16 +1,16 @@
 """empty message
 
-Revision ID: acf20342181e
+Revision ID: 29b261f5edf4
 Revises: 343b406f723d
-Create Date: 2024-02-02 16:47:00.942504
+Create Date: 2024-02-06 13:52:18.973974
 
 """
 from alembic import op
 import sqlalchemy as sa
 
 
 # revision identifiers, used by Alembic.
-revision = 'acf20342181e'
+revision = '29b261f5edf4'
 down_revision = '343b406f723d'
 branch_labels = None
 depends_on = None
@@ -19,7 +19,7 @@
 def upgrade():
     # ### commands auto generated by Alembic - please adjust! ###
     with op.batch_alter_table('future_task', schema=None) as batch_op:
-        batch_op.add_column(sa.Column('archived_for_process_instance_status', sa.Boolean(), nullable=False))
+        batch_op.add_column(sa.Column('archived_for_process_instance_status', sa.Boolean(), server_default=sa.text('false'), nullable=False))
         batch_op.create_index(batch_op.f('ix_future_task_archived_for_process_instance_status'), ['archived_for_process_instance_status'], unique=False)
 
     # ### end Alembic commands ###

diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/models/future_task.py b/spiffworkflow-backend/src/spiffworkflow_backend/models/future_task.py
@@ -8,6 +8,7 @@
 
 from spiffworkflow_backend.models.db import SpiffworkflowBaseDBModel
 from spiffworkflow_backend.models.db import db
+from sqlalchemy.sql import false
 
 
 @dataclass
@@ -17,7 +18,14 @@ class FutureTaskModel(SpiffworkflowBaseDBModel):
     guid: str = db.Column(db.String(36), primary_key=True)
     run_at_in_seconds: int = db.Column(db.Integer, nullable=False, index=True)
     completed: bool = db.Column(db.Boolean, default=False, nullable=False, index=True)
-    archived_for_process_instance_status: bool = db.Column(db.Boolean, default=False, nullable=False, index=True)
+    archived_for_process_instance_status: bool = db.Column(
+        # db.Boolean, default=False, server_default=db.sql.False_(), nullable=False, index=True
+        db.Boolean,
+        default=False,
+        server_default=false(),
+        nullable=False,
+        index=True,
+    )
 
     updated_at_in_seconds: int = db.Column(db.Integer, nullable=False)