Allow getting all secondary keys and values for a KKV top level key #1016
Conversation
WalkthroughWalkthroughThe modification in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- spiffworkflow-backend/src/spiffworkflow_backend/data_stores/kkv.py (2 hunks)
Additional comments: 2
spiffworkflow-backend/src/spiffworkflow_backend/data_stores/kkv.py (2)
- 74-74: The function
getternow acceptssecondary_keyas an optional parameter, aligning with the PR objectives. Ensure all calls to this function are updated accordingly.- 101-101: Using a dictionary comprehension to map
secondary_keytovalueis efficient for this use case. Ensure that the keys are unique to avoid data loss.
| if secondary_key is not None: | ||
| model = ( | ||
| db.session.query(KKVDataStoreEntryModel) | ||
| .filter_by(kkv_data_store_id=store_model.id, top_level_key=top_level_key, secondary_key=secondary_key) | ||
| .first() | ||
| ) | ||
|
|
||
| if model is not None: | ||
| return model.value | ||
| return None | ||
|
|
||
| models = ( | ||
| db.session.query(KKVDataStoreEntryModel) | ||
| .filter_by(kkv_data_store_id=store_model.id, top_level_key=top_level_key, secondary_key=secondary_key) | ||
| .first() | ||
| .filter_by(kkv_data_store_id=store_model.id, top_level_key=top_level_key) | ||
| .all() | ||
| ) | ||
|
|
||
| if model is not None: | ||
| return model.value | ||
| return None | ||
| values = {model.secondary_key: model.value for model in models} | ||
|
|
||
| return values |
There was a problem hiding this comment.
The logic to handle secondary_key being None is correctly implemented, fetching all secondary keys and their values for the given top_level_key. However, consider adding error handling for potential database query failures to improve robustness.
Feature request from @calexh-sar - via the function placed into task data when a KKV data store is being read, allowing fetching all secondary keys and their values instead of just a value for a secondary key.
Summary by CodeRabbit