Store data store specifications in process_group.json

[jbirddog]

Work on #1037 - this is the work for saving the data store specifications in the process_group.json file when a data store is created or updated from the Add a data store button. Currently does not work for data stores at the very top level (see #1038). Next will be syncing the db with the contents of the process_group.json files when a promotion, etc happens.

Summary by CodeRabbit

• New Features
  • Enhanced the data structure of process groups by including data store specifications.
  • Implemented a new functionality to update process group data store specifications based on model information.

[coderabbitai]

Walkthrough

Walkthrough

The recent update introduces a new field, data_store_specifications, to the ProcessGroup class, aimed at enhancing data structure management by including data storage specifications. Additionally, a function, _write_specification_to_process_group, has been added to facilitate the updating of these specifications within a process group through interaction with the ProcessModelService.

Changes

Files	Summary
.../models/process_group.py	Added data_store_specifications field to the ProcessGroup class.
.../routes/data_store_controller.py	Introduced _write_specification_to_process_group function to update data store specifications in a process group.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between bdbb13b and f90ab3b.

Files selected for processing (2)

• spiffworkflow-backend/src/spiffworkflow_backend/models/process_group.py (2 hunks)
• spiffworkflow-backend/src/spiffworkflow_backend/routes/data_store_controller.py (2 hunks)

Additional comments: 2

spiffworkflow-backend/src/spiffworkflow_backend/models/process_group.py (2)

• 20-20: Adding "data_store_specifications" to PROCESS_GROUP_SUPPORTED_KEYS_FOR_DISK_SERIALIZATION ensures that data store specifications are considered during disk serialization. This change aligns with the PR's objective to enhance data store specification management.
• 33-33: The addition of data_store_specifications as a dictionary field in the ProcessGroup class is correctly implemented with a default empty dictionary. This approach is efficient for initializing with no specifications and supports dynamic addition of specifications, adhering to best practices for data structure management.