Feature/tcoz dev updated #1051
Feature/tcoz dev updated #1051
Conversation
Some notes for people that might want to run full-on native, with detail about how Mac hijacks port 7000 and how to get around it.
This reverts commit 096887c.
Some details for user that might be running Python3, Mac, and want to run everything locally/natively.
Uses MUI tooltip, as it behaves more predictably with existing styling, and enables top-level theme config. Top-level configuration for all MUI components can be controlled via overriding the existing theme. See index.tsx. This could be done per user for customization, etc. Enabling JSON module imports in tsconfig.json seemed to fix the error in ReactDiagramEditor
…across the board w/ burnettk
|
Warning Rate Limit Exceeded@burnettk has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 8 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe updates involve enhancing user experience through tooltip integration across various components, a new tooltip component using Material-UI, and code cleanup including removal of unused imports. Additionally, updates include interface enhancements to support tooltips, theme setup adjustments with Material-UI's Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 4
Configuration used: .coderabbit.yaml
Files selected for processing (10)
- spiffworkflow-frontend/src/components/NavigationBar.tsx (4 hunks)
- spiffworkflow-frontend/src/components/ProcessInstanceListTabs.tsx (2 hunks)
- spiffworkflow-frontend/src/components/ReactDiagramEditor.tsx (1 hunks)
- spiffworkflow-frontend/src/components/SpiffTabs.tsx (2 hunks)
- spiffworkflow-frontend/src/components/SpiffTooltip.tsx (1 hunks)
- spiffworkflow-frontend/src/components/TaskRouteTabs.tsx (1 hunks)
- spiffworkflow-frontend/src/extension_ui_schema_interfaces.ts (1 hunks)
- spiffworkflow-frontend/src/index.tsx (1 hunks)
- spiffworkflow-frontend/src/interfaces.ts (1 hunks)
- spiffworkflow-frontend/tsconfig.json (1 hunks)
Files skipped from review due to trivial changes (1)
- spiffworkflow-frontend/src/components/ReactDiagramEditor.tsx
Additional comments: 11
spiffworkflow-frontend/src/components/TaskRouteTabs.tsx (1)
- 12-26: Ensure that the
tooltipproperty values are accurate and provide meaningful information to the user.spiffworkflow-frontend/src/components/SpiffTabs.tsx (2)
- 5-5: The import of
SpiffTooltipis correctly added to support tooltip functionality for tabs.- 28-32: The implementation of
SpiffTooltipwrapping theTabcomponent is correct, ensuring tooltips are displayed as intended.spiffworkflow-frontend/src/index.tsx (3)
- 3-3: The import of
createThemeandThemeProviderfrom@mui/material/stylesis correctly added for theme customization.- 18-39: The creation of
defaultThemeandoverrideThemeusingcreateThemeis correctly implemented, allowing for theme customization, especially for tooltips.- 44-48: Wrapping the
<App />component with nestedThemeProvidercomponents to apply thedefaultThemeandoverrideThemeis correctly implemented.spiffworkflow-frontend/src/components/ProcessInstanceListTabs.tsx (2)
- 8-8: The import of
SpiffTooltipis correctly added to support tooltip functionality for tabs.- 32-63: The implementation of
SpiffTooltipwrapping theTabcomponents is correct, ensuring tooltips are displayed as intended for each tab.spiffworkflow-frontend/src/extension_ui_schema_interfaces.ts (1)
- 66-66: The addition of the
tooltipfield to theUiSchemaUxElementinterface is correctly implemented, allowing for tooltip customization in the UI schema.spiffworkflow-frontend/src/interfaces.ts (1)
- 495-495: The addition of the
tooltipfield to theSpiffTabinterface is correctly implemented, allowing for tooltip customization on tabs.spiffworkflow-frontend/src/components/NavigationBar.tsx (1)
- 225-233: The tooltip title is dynamically set based on the
uxElement?.tooltip. Ensure thatuxElement.tooltipis always defined to avoid displaying empty tooltips.Verify that all
uxElementobjects passed toextensionHeaderMenuItemElementhave a non-emptytooltipproperty.
Uses MUI tooltip, as it behaves more predictably with existing styling, and enables top-level theme config.
Top-level configuration for all MUI components can be controlled via overriding the existing theme. See index.tsx. This could be done per user for customization, etc.
Enabling JSON module imports in tsconfig.json seemed to fix the error in ReactDiagramEditor
this is basically the same as #1039, but with the documentation updates removed, since they have already been incorporated in main and subsequently updated and moved around a bit. This version also adds a
SpiffTooltipcomponent so we can switch between carbon quickly and deduplicate thearrowprop.Summary by CodeRabbit
SpiffTooltipcomponent for enhanced tooltip functionality.createThemeandThemeProvider.ReactDiagramEditorby removing unnecessary import.