feature/allow-data-stores-in-root-pg-file

[jasquat]

Implements #1038

This allows for the root of the process model repo to add a process group file if it does not already exist when adding a data store.

Summary by CodeRabbit

• New Features

  • Enhanced data store functionality to ensure specifications are properly associated with process groups before saving.
  • Added a conditional creation feature for process groups in the workflow backend, improving flexibility in process management.
  • Introduced a delay for tooltip appearance in the frontend, enhancing user interface interactions.

• Refactor

  • Updated logic for handling process group retrieval and data store specifications, optimizing performance and reliability.

• Tests

  • Added new test cases to validate the improved functionality of the reference cache service, ensuring robustness and accuracy.

[coderabbitai]

Walkthrough

Walkthrough

The recent updates focus on enhancing the functionality and user experience of the SpiffWorkflow platform. Changes include improvements to the data store upsert process, conditional creation of process groups, enhanced testing for reference cache service, and a user interface adjustment for tooltips. These modifications aim to streamline workflows, ensure robustness through testing, and improve UI responsiveness.

Changes

File(s)	Summary
.../routes/data_store_controller.py	Updated _data_store_upsert to call _write_specification_to_process_group before committing to the database. Adjusted logic in _write_specification_to_process_group.
.../services/process_model_service.py	Added create_if_not_exists boolean parameter to get_process_group method, defaulting to False.
.../unit/test_reference_cache_service.py	Introduced new test cases for verifying data store functionality within the reference cache service.
spiffworkflow-frontend/.../SpiffTooltip.tsx	Added enterDelay={500} prop to Tooltip for delayed tooltip appearance.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 2

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between cdfe4aa and aec8b24.

Files selected for processing (4)

• spiffworkflow-backend/src/spiffworkflow_backend/routes/data_store_controller.py (1 hunks)
• spiffworkflow-backend/src/spiffworkflow_backend/services/process_model_service.py (1 hunks)
• spiffworkflow-backend/tests/spiffworkflow_backend/unit/test_reference_cache_service.py (2 hunks)
• spiffworkflow-frontend/src/components/SpiffTooltip.tsx (1 hunks)

Additional comments: 2

spiffworkflow-frontend/src/components/SpiffTooltip.tsx (1)

• 14-14: The addition of enterDelay={500} to the Tooltip component is a good enhancement for improving user experience by introducing a delay before the tooltip appears. This change is straightforward and integrates well with the existing component structure.

spiffworkflow-backend/src/spiffworkflow_backend/services/process_model_service.py (1)

• 459-468: The addition of the create_if_not_exists parameter to the get_process_group method is a well-implemented enhancement that supports the feature's core functionality by allowing conditional creation of a process group. This change is logically sound and maintains backward compatibility by defaulting to False. It's recommended to review the usage of this parameter in other parts of the codebase to ensure it is used appropriately and does not introduce unintended side effects.

[burnettk]

unrelated, but just wanted to delay a bit longer than the default of 100 milliseconds before popping open the tooltips.