Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shortcut to view diagram from instance show #1082

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

burnettk
Copy link
Contributor

@burnettk burnettk commented Feb 21, 2024

adds a keyboard shortcut to skip over to the diagram from process instance show

Summary by CodeRabbit

  • New Features
    • Added ProcessModel import for enhanced functionality.
    • Implemented processModelFileCreatePath to target URIs.
    • Introduced keyboard shortcut shortcutLoadPrimaryFile for quick diagram viewing.

Copy link
Contributor

coderabbitai bot commented Feb 21, 2024

Walkthrough

Walkthrough

The recent update enhances the process instance display functionality by introducing new features. These include importing the ProcessModel, adding a path for creating process model files, and implementing a keyboard shortcut for quickly loading primary files related to diagrams. These changes are designed to streamline the user interface and improve efficiency in interacting with process diagrams.

Changes

File Change Summary
.../src/routes/ProcessInstanceShow.tsx - Imported ProcessModel
- Added processModelFileCreatePath
- Implemented shortcutLoadPrimaryFile function

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 802d808 and 1d8bbbd.
Files selected for processing (1)
  • spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx (3 hunks)
Additional comments: 3
spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx (3)
  • 67-67: The import of ProcessModel is correctly added to utilize process model data effectively for the new feature.
  • 161-161: The addition of processModelFileCreatePath to target URIs is appropriate for dynamically generating or identifying the diagram's location based on the process model information.
  • 220-223: The integration of the keyboard shortcut 'd,enter' to trigger the shortcutLoadPrimaryFile function is correctly implemented within the keyboardShortcuts object. This addition aligns with the PR's objective to enhance user experience by allowing quick navigation to the diagram view. The labeling and function mapping are clear and concise.

spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 1d8bbbd and 5cfc186.
Files selected for processing (1)
  • spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx

@burnettk burnettk merged commit ea108c6 into main Feb 22, 2024
22 checks passed
@burnettk burnettk deleted the feature/shortcut-to-diagram branch February 22, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant