feature/pin-auth-exlusions-to-controller

[jasquat]

This updates the should_disable_auth_for_request method to also take the controller into account instead of just the function. This way if a method is named the same as a method in another controller it won't unintentionally be made unauth'd.

Summary by CodeRabbit

• Refactor
  • Enhanced authentication exclusion logic to improve app security and efficiency.

[coderabbitai]

Walkthrough

Walkthrough

The update involves redefining how functions are excluded from authentication checks in the backend service. The authentication exclusion mechanism has been transformed from a list structure to a dictionary format. This change enables a more specific mapping of function names to their corresponding controller names, thereby refining the authentication exclusion process.

Changes

File Path	Change Summary
.../services/authorization_service.py	Updated authentication_exclusion_list to a dictionary format, mapping function names to controller names for precise authentication exclusion logic.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 802d808 and 90f3be6.

Files selected for processing (1)

• spiffworkflow-backend/src/spiffworkflow_backend/services/authorization_service.py (2 hunks)

Additional comments: 1

spiffworkflow-backend/src/spiffworkflow_backend/services/authorization_service.py (1)

• 234-244: The transformation of authentication_exclusion_list from a list to a dictionary, mapping function names to their corresponding controller names, is a significant improvement in terms of security and specificity. This change effectively addresses the risk of unintentionally applying authentication exclusions to functions with the same name across different controllers.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 90f3be6 and 160dc64.

Files selected for processing (1)

• spiffworkflow-backend/src/spiffworkflow_backend/services/authorization_service.py (3 hunks)

Files skipped from review as they are similar to previous changes (1)

• spiffworkflow-backend/src/spiffworkflow_backend/services/authorization_service.py