Update secrets programmatically #1122
Conversation
WalkthroughWalkthroughThe changes focus on enhancing backend configuration and database capabilities. A new Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: .coderabbit.yaml
Files selected for processing (4)
- Makefile (3 hunks)
- spiffworkflow-backend/dev.Dockerfile (1 hunks)
- spiffworkflow-backend/dev.docker-compose.yml (1 hunks)
- spiffworkflow-backend/src/spiffworkflow_backend/scripts/set_secret.py (1 hunks)
spiffworkflow-backend/src/spiffworkflow_backend/scripts/set_secret.py
Outdated
Show resolved
Hide resolved
…cret.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- spiffworkflow-backend/src/spiffworkflow_backend/scripts/set_secret.py (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- spiffworkflow-backend/src/spiffworkflow_backend/scripts/set_secret.py
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- spiffworkflow-backend/src/spiffworkflow_backend/scripts/set_secret.py (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- spiffworkflow-backend/src/spiffworkflow_backend/scripts/set_secret.py
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (3)
- Makefile (3 hunks)
- spiffworkflow-backend/dev.Dockerfile (1 hunks)
- spiffworkflow-backend/dev.docker-compose.yml (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- Makefile
- spiffworkflow-backend/dev.Dockerfile
Additional comments: 1
spiffworkflow-backend/dev.docker-compose.yml (1)
- 13-13: The addition of a default value for
SPIFFWORKFLOW_BACKEND_ENVusing the${VARIABLE:-default}syntax is a good practice. It ensures that the service has a sensible default environment, enhancing the configurability and robustness of the application. This change aligns well with Docker Compose best practices.
Makefile
Outdated
| be-sqlite: | ||
| @if [ ! -f "$(BACKEND_CONTAINER)/src/instance/db_$(SPIFFWORKFLOW_BACKEND_ENV).sqlite3" ]; then \ | ||
| echo "SQLite database file does not exist: $(BACKEND_CONTAINER)/src/instance/db_$(SPIFFWORKFLOW_BACKEND_ENV).sqlite3"; \ | ||
| exit 1; \ |
There was a problem hiding this comment.
maybe indent this exit 1 line?
Work on #1044 - allows processes run with admin permissions to create/update a secret from a script task. Current use case is setting the session token for Iplict api calls. Also added a make target to load the current sqlitedb to help with debugging.
Summary by CodeRabbit
New Features
Chores
sqlite3.