Put open in new tab arrow to the right of the button in process instance tables

[burnettk]

Put open in new tab arrow to the right of the button in process instance tables
make tooltip expand to the left

re: #1030

Summary by CodeRabbit

• Style and UI Enhancements
  • Updated button styles and positioning in the Process Instance List.
  • Improved tooltip visibility and alignment for a more intuitive user interface.

[coderabbitai]

Walkthrough

Walkthrough

This update enhances the user interface of a process instance list table by refining visual elements and interaction cues. It includes adjustments to styling, layout, and accessibility features, such as tooltip positioning and button alignment, to improve user experience and consistency across the interface.

Changes

File Path	Change Summary
.../ProcessInstanceListTable.tsx	- Added TableCell import - New CSS class and style adjustments - Tooltip position and button alignment changes
spiffworkflow-frontend/src/index.css	- Added .pi-show-new-tab-button CSS style with positioning

Related issues

• sartography/spiff-arena#863: The PR's focus on UI consistency, particularly in button styling and positioning, aligns with the objectives of enhancing visual and functional aspects of the interface. The addition of tooltips and adjustments to element spacing and alignment could indirectly contribute to achieving a more consistent and user-friendly UI as outlined in the issue.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 8a773c8 and 7b10777.

Files selected for processing (2)

• spiffworkflow-frontend/src/components/ProcessInstanceListTable.tsx (3 hunks)
• spiffworkflow-frontend/src/index.css (1 hunks)

Files skipped from review due to trivial changes (1)

• spiffworkflow-frontend/src/index.css

Additional comments: 5

spiffworkflow-frontend/src/components/ProcessInstanceListTable.tsx (5)

• 12-12: The import of TableCell from @carbon/react is correctly added to support the alignment changes mentioned in the PR objectives.
• 523-523: Adding the new CSS class pi-show-new-tab-button aligns with the PR's objective to adjust the positioning of the "open in new tab" arrow. This change is consistent with the description provided in the AI-generated summary.
• 526-526: Reducing the button width from 60px to 50px is mentioned in the PR objectives to streamline the UI. However, consider verifying this change with the design team or through user testing to ensure it enhances usability without compromising accessibility or user experience.
• 529-530: The addition of tooltipPosition="left" for the button icon is a thoughtful change that addresses the PR's objective to improve tooltip visibility and avoid overlap with other UI elements.
• 542-547: The logic to conditionally render the TableCell with alignment to the right or a standard td based on the process instance status is a good approach to handle different UI states. However, consider abstracting this logic into a separate function or component for better readability and maintainability. This would also make it easier to extend or modify this behavior in the future.