-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to screenshots and tables #1489
Conversation
WalkthroughThe recent updates focus on enhancing documentation and simplifying access to information. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
Out of diff range and nitpick comments (5)
docs/Building_Diagrams/Script_Tasks.md (3)
Line range hint
1-1
: Ensure the document starts with a blank line above the heading for proper formatting.+ # Script Tasks
Line range hint
41-41
: Add a blank line above the fenced code block for proper markdown formatting.+ ``` python
Line range hint
60-60
: Add a blank line below the fenced code block for proper markdown formatting.} +
docs/Getting_Started/quick_start.md (2)
Line range hint
22-22
: Add a blank line above the fenced code block for proper markdown formatting.+ ```{image} ./images/Login.png
Line range hint
366-366
: Ensure there is a blank line above the heading "Milestones" for proper markdown formatting.+ ### Milestones
| get_current_task_info | Returns information about the current task. | | ||
| get_current_user | Returns the current user. | | ||
| get_data_sizes | Returns information about the size of task data. | | ||
| get_encoded_file_data | Returns the encoded file data. This is a very expensive call. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify the description of get_encoded_file_data
to avoid using "very" as an intensifier. Consider a more precise description.
- Returns the encoded file data. This is a very expensive call.
+ Returns the encoded file data. Note: This operation is resource-intensive.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| get_encoded_file_data | Returns the encoded file data. This is a very expensive call. | | |
| get_encoded_file_data | Returns the encoded file data. Note: This operation is resource-intensive. | |
| get_localtime | Converts a Datetime object into a Datetime object for a specific timezone. | | ||
| get_process_initiator_user | Returns the user that initiated the process instance. | | ||
| get_secret | Returns the value for a previously configured secret. | | ||
| get_task_data_value | Checks if a given value is in task data and returns its value. If it does not exist or is None, it returns the default | value. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table row for get_task_data_value
is malformed with an extra column. Ensure the table formatting is consistent.
- | get_task_data_value | Checks if a given value is in task data and returns its value. If it does not exist or is None, it returns the default | value.
+ | get_task_data_value | Checks if a given value is in task data and returns its value. If it does not exist or is None, it returns the default value.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| get_task_data_value | Checks if a given value is in task data and returns its value. If it does not exist or is None, it returns the default | value. | | |
| get_task_data_value | Checks if a given value is in task data and returns its value. If it does not exist or is None, it returns the default value. |
| refresh_permissions | Adds permissions using a dictionary. | | ||
| set_user_properties | Sets given user properties on the current user. | | ||
| times_executed_by_user | Returns the number of times the user has started an instance of the current process model. | | ||
| user_has_started_instance | Returns a boolean indicating if the user has started an instance of the current process model. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the file ends with a single newline character for proper formatting.
| user_has_started_instance | Returns a boolean indicating if the user has started an instance of the current process model. |
+
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| user_has_started_instance | Returns a boolean indicating if the user has started an instance of the current process model. | | |
| user_has_started_instance | Returns a boolean indicating if the user has started an instance of the current process model. | |
@@ -368,6 +368,8 @@ This can help you manage your workflows more efficiently and keep track of the p | |||
### Milestones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure there is a blank line below the heading "Milestones" for proper markdown formatting.
### Milestones
+
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
### Milestones | |
### Milestones | |
@@ -498,4 +500,4 @@ | |||
- **MAYBE Status**: Indicates that the task still exists within SpiffWorkflow. While these tasks could be omitted for clarity, retaining them provides a complete picture of the workflow's execution. | |||
|
|||
Viewing task instance history in SpiffWorkflow is now more streamlined and informative, thanks to recent updates. | |||
Users can effectively track each task's execution, status, and timing, gaining insights into the workflow's overall performance. | |||
Users can effectively track each task's execution, status, and timing, gaining insights into the workflow's overall performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the file ends with a single newline character for proper formatting.
Users can effectively track each task's execution, status, and timing, gaining insights into the workflow's overall performance.
+
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Users can effectively track each task's execution, status, and timing, gaining insights into the workflow's overall performance. | |
Users can effectively track each task's execution, status, and timing, gaining insights into the workflow's overall performance. | |
Summary by CodeRabbit