Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to screenshots and tables #1489

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

usama9500
Copy link
Collaborator

@usama9500 usama9500 commented May 3, 2024

  • Added new screenshots in Quickstart guide as per feedback
  • Table for script task functions for readability purpose

Summary by CodeRabbit

  • Documentation
    • Updated the "Script Tasks" documentation to include a table format for better readability and quick reference of functions.
    • Enhanced the "Quick Start" guide with updated images for milestones and events to reflect the latest interface.
  • New Features
    • Introduced a range of new functions to enhance user interaction and data management within the system, such as retrieving user and task information, managing permissions, and handling environment-specific data.

Copy link
Contributor

coderabbitai bot commented May 3, 2024

Walkthrough

The recent updates focus on enhancing documentation and simplifying access to information. Script_Tasks.md has been reformatted to include a detailed table of script functions, improving readability and accessibility. Meanwhile, quick_start.md in the Getting Started section has updated image references to better reflect the content discussed. These changes aim to streamline user interaction and understanding of the system's functionalities.

Changes

File Path Change Summary
docs/.../Script_Tasks.md Updated function documentation into a table format, added and described multiple script functions.
docs/.../quick_start.md Updated image references to better align with content.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

Out of diff range and nitpick comments (5)
docs/Building_Diagrams/Script_Tasks.md (3)

Line range hint 1-1: Ensure the document starts with a blank line above the heading for proper formatting.

+ 
# Script Tasks

Line range hint 41-41: Add a blank line above the fenced code block for proper markdown formatting.

+
``` python

Line range hint 60-60: Add a blank line below the fenced code block for proper markdown formatting.

}
+
docs/Getting_Started/quick_start.md (2)

Line range hint 22-22: Add a blank line above the fenced code block for proper markdown formatting.

+
```{image} ./images/Login.png

Line range hint 366-366: Ensure there is a blank line above the heading "Milestones" for proper markdown formatting.

+
### Milestones

| get_current_task_info | Returns information about the current task. |
| get_current_user | Returns the current user. |
| get_data_sizes | Returns information about the size of task data. |
| get_encoded_file_data | Returns the encoded file data. This is a very expensive call. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify the description of get_encoded_file_data to avoid using "very" as an intensifier. Consider a more precise description.

- Returns the encoded file data. This is a very expensive call.
+ Returns the encoded file data. Note: This operation is resource-intensive.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
| get_encoded_file_data | Returns the encoded file data. This is a very expensive call. |
| get_encoded_file_data | Returns the encoded file data. Note: This operation is resource-intensive. |

| get_localtime | Converts a Datetime object into a Datetime object for a specific timezone. |
| get_process_initiator_user | Returns the user that initiated the process instance. |
| get_secret | Returns the value for a previously configured secret. |
| get_task_data_value | Checks if a given value is in task data and returns its value. If it does not exist or is None, it returns the default | value. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table row for get_task_data_value is malformed with an extra column. Ensure the table formatting is consistent.

- | get_task_data_value              | Checks if a given value is in task data and returns its value. If it does not exist or is None, it returns the default                               | value.
+ | get_task_data_value              | Checks if a given value is in task data and returns its value. If it does not exist or is None, it returns the default value.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
| get_task_data_value | Checks if a given value is in task data and returns its value. If it does not exist or is None, it returns the default | value. |
| get_task_data_value | Checks if a given value is in task data and returns its value. If it does not exist or is None, it returns the default value.

| refresh_permissions | Adds permissions using a dictionary. |
| set_user_properties | Sets given user properties on the current user. |
| times_executed_by_user | Returns the number of times the user has started an instance of the current process model. |
| user_has_started_instance | Returns a boolean indicating if the user has started an instance of the current process model. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the file ends with a single newline character for proper formatting.

| user_has_started_instance        | Returns a boolean indicating if the user has started an instance of the current process model. |
+

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
| user_has_started_instance | Returns a boolean indicating if the user has started an instance of the current process model. |
| user_has_started_instance | Returns a boolean indicating if the user has started an instance of the current process model. |

@@ -368,6 +368,8 @@ This can help you manage your workflows more efficiently and keep track of the p
### Milestones
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure there is a blank line below the heading "Milestones" for proper markdown formatting.

### Milestones
+

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
### Milestones
### Milestones

@@ -498,4 +500,4 @@
- **MAYBE Status**: Indicates that the task still exists within SpiffWorkflow. While these tasks could be omitted for clarity, retaining them provides a complete picture of the workflow's execution.

Viewing task instance history in SpiffWorkflow is now more streamlined and informative, thanks to recent updates.
Users can effectively track each task's execution, status, and timing, gaining insights into the workflow's overall performance.
Users can effectively track each task's execution, status, and timing, gaining insights into the workflow's overall performance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the file ends with a single newline character for proper formatting.

Users can effectively track each task's execution, status, and timing, gaining insights into the workflow's overall performance.
+

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
Users can effectively track each task's execution, status, and timing, gaining insights into the workflow's overall performance.
Users can effectively track each task's execution, status, and timing, gaining insights into the workflow's overall performance.

@burnettk burnettk merged commit adab730 into main May 8, 2024
23 checks passed
@burnettk burnettk deleted the Updates_screenshots_tables branch May 8, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants