feature/fix-rjsf-date-with-abbr-month

[jasquat]

Fixes #853

This updates our check for dates when changing the format to ymd so it can better support various date formats. Instead of checking format of date to see if it is like dd-MM, check if it's already ymd and then attempt to create a new date with it if not. If the new date is invalid then just return the original string.

Summary by CodeRabbit

• Bug Fixes
  • Improved date handling to support yyyy-MM-dd format and better manage invalid dates.

[coderabbitai]

Walkthrough

Walkthrough

The update to DateAndTimeService.tsx addresses issues with the date picker functionality. It ensures that dates in the yyyy-MM-dd format are processed correctly and that invalid date strings are robustly checked using isNaN. This change aims to fix the bug where selected dates were resetting and the inability to type a date directly into the picker.

Changes

File	Summary of Changes
spiffworkflow-frontend/src/services/DateAndTimeService.tsx	Modified dateStringToYMDFormat to handle yyyy-MM-dd format and invalid date strings with isNaN.

Assessment against linked issues

Objective	Addressed	Explanation
#853: Bug with date resetting when selected	✅
#853: Bug with inability to type a value in the date picker	✅
#853: Bug with date changing to a different format when typed	✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 08547bb and 686175b.

Files selected for processing (1)

• spiffworkflow-frontend/src/services/DateAndTimeService.tsx (1 hunks)

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 686175b and e6fea1b.

Files selected for processing (1)

• spiffworkflow-frontend/src/services/DateAndTimeService.tsx (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• spiffworkflow-frontend/src/services/DateAndTimeService.tsx