Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempt to upgrade github actions and keep coverage working #950

Merged
merged 2 commits into from
Feb 2, 2024
Merged

attempt to upgrade github actions and keep coverage working #950

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84feb06
attempt to upgrade github actions and keep coverage working
burnettk Feb 2, 2024
80bb62a
screw it, will attempt to only upload once, so just enforce it
burnettk Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ jobs:
os: "ubuntu-latest",
session: "tests",
database: "mysql",
upload_coverage: true,
}
- {
python: "3.12",
Expand Down Expand Up @@ -186,10 +185,10 @@ jobs:
- name: Upload coverage data
# pin to upload coverage from only one matrix entry, otherwise coverage gets confused later
if: matrix.upload_coverage
uses: "actions/upload-artifact@v3"
uses: "actions/upload-artifact@v4.3.0"
# this action doesn't seem to respect working-directory so include working-directory value in path
with:
name: coverage-data
name: coverage-data-${{ matrix.runs-on }}
path: "spiffworkflow-backend/.coverage.*"

# - name: Upload documentation
Expand Down Expand Up @@ -275,9 +274,10 @@ jobs:
poetry --version

- name: Download coverage data
uses: actions/download-artifact@v3.0.2
uses: actions/download-artifact@v4.1.1
with:
name: coverage-data
name: coverage-data-*
merge-multiple: true
# this action doesn't seem to respect working-directory so include working-directory value in path
path: spiffworkflow-backend

Expand Down
Loading