remove old form builder and references to it

[jasquat]

Fixes #804

This removes the old form builder since it should no longer be used.

Summary by CodeRabbit

• Refactor
  • Simplified the user interface by removing the "Form Builder" button condition and streamlining the process model routing.
• Chores
  • Cleaned up unused interfaces to enhance code maintainability.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes involve simplifying the UI and functionality around form handling in the spiffworkflow-frontend project. Specifically, interfaces related to form fields and JSON schema forms have been removed, along with the associated JsonSchemaFormBuilder component and its routing logic. Additionally, the logic for displaying a "Form Builder" button based on file extension criteria has been simplified. These alterations streamline the project's codebase and potentially its user interface.

Changes

File Path	Change Summary
.../src/interfaces.ts	Removed FormField and JsonSchemaForm interfaces
.../src/routes/ProcessModelRoutes.tsx	Removed JsonSchemaFormBuilder component import and route definition
.../src/routes/ReactFormEditor.tsx	Simplified logic for displaying "Form Builder" button

Assessment against linked issues

Objective (Issue Number)	Addressed	Explanation
Display proper error message for invalid Form Builder ID (#804)	❌	The code changes do not directly address the requirement to display a proper error message for invalid ID entries. The removal of form-related components and simplification of logic does not inherently resolve the issue of validating and providing feedback for Form Builder ID entries with invalid characters.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between c36ed57 and a3f2e81.

Files selected for processing (3)

• spiffworkflow-frontend/src/interfaces.ts (1 hunks)
• spiffworkflow-frontend/src/routes/ProcessModelRoutes.tsx (2 hunks)
• spiffworkflow-frontend/src/routes/ReactFormEditor.tsx (3 hunks)

Additional comments: 3

spiffworkflow-frontend/src/routes/ProcessModelRoutes.tsx (1)

• 1-4: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-18]

Confirmed removal of JsonSchemaFormBuilder component import and route definition. Ensure all references to this component are removed throughout the project to avoid broken imports or routing errors.

spiffworkflow-frontend/src/routes/ReactFormEditor.tsx (1)

• 57-62: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-299]

Confirmed removal of conditional rendering for the "Form Builder" button based on file extension. Ensure this change aligns with UI and functionality requirements and does not introduce unintended side effects.

spiffworkflow-frontend/src/interfaces.ts (1)

• 367-372: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-299]

Confirmed removal of FormField and JsonSchemaForm interfaces. Ensure all dependencies on these interfaces are resolved and that their removal does not negatively impact other parts of the application.