-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to fix mac build mysql lib install issue with poetry #987
Conversation
Warning Rate Limit Exceeded@burnettk has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 58 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe change highlights an adjustment in the project's continuous integration setup, specifically targeting the MySQL version used in tests. By pinning MySQL to version 8.0, the modification addresses compatibility issues encountered with MySQL version 8.3, which were interfering with the Poetry installation process during automated testing workflows. This proactive measure ensures that the testing environment remains stable and prevents disruptions caused by the newer MySQL version. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- .github/workflows/tests.yml (1 hunks)
Additional comments: 1
.github/workflows/tests.yml (1)
- 178-180: The approach to pin MySQL version to 8.0 on macOS by using
brew install mysql@8.0 pkg-config
is a valid workaround for the compatibility issue with MySQL 8.3. However, ensure that this version pinning does not introduce any compatibility issues with the current project dependencies or future updates.
mysql 8.3 was released in december, and may have broken this
Summary by CodeRabbit