Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attrs minimum dependency #142

Closed
jayvdb opened this issue Mar 7, 2019 · 1 comment
Closed

attrs minimum dependency #142

jayvdb opened this issue Mar 7, 2019 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Mar 7, 2019

[   32s] [149/230] cumulate python2-attrs-17.4.0-lp151.2.2
...
[   86s] ImportError while loading conftest '/home/abuild/rpmbuild/BUILD/requirementslib-1.4.2/tests/conftest.py'.
[   86s] /usr/lib/python2.7/site-packages/six.py:709: in exec_
[   86s]     exec("""exec _code_ in _globs_, _locs_""")
[   86s] tests/conftest.py:10: in <module>
[   86s]     import requirementslib.utils
[   86s] ../../BUILDROOT/python-requirementslib-1.4.2-lp151.3.1.x86_64/usr/lib/python2.7/site-packages/requirementslib/__init__.py:9: in <module>
[   86s]     from .models.lockfile import Lockfile
[   86s] ../../BUILDROOT/python-requirementslib-1.4.2-lp151.3.1.x86_64/usr/lib/python2.7/site-packages/requirementslib/models/lockfile.py:15: in <module>
[   86s]     from .requirements import Requirement
[   86s] ../../BUILDROOT/python-requirementslib-1.4.2-lp151.3.1.x86_64/usr/lib/python2.7/site-packages/requirementslib/models/requirements.py:43: in <module>
[   86s]     from .setup_info import SetupInfo, _prepare_wheel_building_kwargs
[   86s] ../../BUILDROOT/python-requirementslib-1.4.2-lp151.3.1.x86_64/usr/lib/python2.7/site-packages/requirementslib/models/setup_info.py:454: in <module>
[   86s]     class Extra(object):
[   86s] ../../BUILDROOT/python-requirementslib-1.4.2-lp151.3.1.x86_64/usr/lib/python2.7/site-packages/requirementslib/models/setup_info.py:456: in Extra
[   86s]     requirements = attr.ib(factory=frozenset, cmp=True, type=frozenset)
[   86s] E   TypeError: attrib() got an unexpected keyword argument 'factory'

A quick scan through history of attrs suggests this is the functionality needed python-attrs/attrs@780e1e5 , and thus the minimum version needed is at least 18.1.0

@techalchemy
Copy link
Member

definitely, thanks for the report

feel free to PR a pin for this if you like (I'd be glad to do it also) & sorry for the bug!

@techalchemy techalchemy added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Mar 7, 2019
techalchemy added a commit that referenced this issue Mar 8, 2019
- Fixes #142

Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy added a commit that referenced this issue Mar 31, 2020
- Fixes #142

Signed-off-by: Dan Ryan <dan@danryan.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants