Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP508 style URLs should raise helpful error when parsing egg fragments in url #146

Closed
techalchemy opened this issue Mar 17, 2019 · 1 comment
Closed

PEP508 style URLs should raise helpful error when parsing egg fragments in url #146

techalchemy opened this issue Mar 17, 2019 · 1 comment
Assignees
@techalchemy
Labels
good first issue Good for newcomers input parsing vcs

Comments

@techalchemy
Copy link
Member

If users provide a pep-508 compliant URL except they also supply a #egg=name fragment, we currently simply fail resolution -- we could raise a proper error with helpful information here or we could simply strip the egg fragment during resolution
@techalchemy techalchemy self-assigned this Mar 17, 2019
@techalchemy
Copy link
Member Author

Ref: pypa/pipenv#3497

techalchemy added a commit that referenced this issue Mar 17, 2019
@techalchemy
Merge egg fragment with name in pep508 reqs
aea76eb 
- For PEP508 direct url requirements, egg fragments and names should be
  merged rather than combined when reconstructing urls
- Fixes #146

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy mentioned this issue Mar 17, 2019
Merged
techalchemy added a commit that referenced this issue Mar 31, 2020
@techalchemy
Merge egg fragment with name in pep508 reqs
edbfd8a 
- For PEP508 direct url requirements, egg fragments and names should be
  merged rather than combined when reconstructing urls
- Fixes #146

Signed-off-by: Dan Ryan <dan@danryan.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@techalchemy techalchemy

Labels
good first issue Good for newcomers input parsing vcs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@techalchemy