Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LRU caching doesn't work when passing a tuple of tuples #171

Closed
techalchemy opened this issue Jun 8, 2019 · 0 comments · Fixed by #172
Closed

LRU caching doesn't work when passing a tuple of tuples #171

techalchemy opened this issue Jun 8, 2019 · 0 comments · Fixed by #172

Comments

@techalchemy
Copy link
Member

When calling requirementslib.models.markers.cleanup_pyspecs with a SpecifierSet instance, the given instance is split into a set of tuples and then converted to a tuple for hashing (for lru_cache compatibility specifically).

This doesn't seem to work, and it causes a lot of issues. We just need to drop the lru_cache from the specified function
techalchemy added a commit that referenced this issue Jun 8, 2019
@techalchemy
Remove LRU Cache from operator grouping function
64cc2ef 
- Clean up and flatten overcomplicated code
- Add helper function for generating markers from specifiers
- Fixes #171

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy mentioned this issue Jun 8, 2019
Merged
techalchemy added a commit that referenced this issue Mar 31, 2020
@techalchemy
Remove LRU Cache from operator grouping function
49436ac 
- Clean up and flatten overcomplicated code
- Add helper function for generating markers from specifiers
- Fixes #171

Signed-off-by: Dan Ryan <dan@danryan.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove LRU Cache from operator grouping function sarugaku/requirementslib
1 participant
@techalchemy