Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance requirements,txt compatible line generation when writing markers #174

Closed
techalchemy opened this issue Jun 24, 2019 · 0 comments · Fixed by #175
Closed

Enhance requirements,txt compatible line generation when writing markers #174

techalchemy opened this issue Jun 24, 2019 · 0 comments · Fixed by #175

Comments

@techalchemy
Copy link
Member

Currently when writing markers, our format is not compatible with the proper requirements.txt format or with the standard pip install format (depending on whether we handle this with as_list or not. This needs to be resolved for writing out requirements in pipenv as part of a refactor of pip_install, and I am exanding some test functionality here as well so I figured i'd track this in a separate issue from #77
techalchemy added a commit that referenced this issue Jun 24, 2019
@techalchemy
Add improved requirements output and test generation
24596c9 
- Fixes #77
- Fixes #174

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy mentioned this issue Jun 24, 2019
Merged
techalchemy added a commit that referenced this issue Mar 31, 2020
@techalchemy
Add improved requirements output and test generation
6c4f061 
- Fixes #77
- Fixes #174

Signed-off-by: Dan Ryan <dan@danryan.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add improved requirements output and test generation sarugaku/requirementslib
1 participant
@techalchemy