Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spinner encoding attempts to encode strings too many times, causing failures on python 2 #69

Closed
techalchemy opened this issue Mar 12, 2019 · 0 comments
Closed

Spinner encoding attempts to encode strings too many times, causing failures on python 2 #69

techalchemy opened this issue Mar 12, 2019 · 0 comments
Assignees
@techalchemy
Labels
bug Something isn't working in progress

Comments

@techalchemy
Copy link
Member 

Traceback (most recent call last):
  File "/home/hawk/.pyenv/versions/2.7.16/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/home/hawk/.pyenv/versions/2.7.16/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/home/hawk/git/pipenv/pipenv/vendor/vistir/spin.py", line 369, in _spin
    out = self._compose_out(spin_phase)
  File "/home/hawk/git/pipenv/pipenv/vendor/vistir/spin.py", line 352, in _compose_out
    out = decode_output("\r{0} {1}".format(frame, text))
UnicodeEncodeError: 'ascii' codec can't encode character u'\u280b' in position 0: ordinal not in range(128)
@techalchemy techalchemy added bug Something isn't working in progress labels Mar 12, 2019
@techalchemy techalchemy self-assigned this Mar 12, 2019
techalchemy added a commit that referenced this issue Mar 12, 2019
@techalchemy
Fix spinner output encoding
3177183 
- Fixes #69
- avoids double encoding text on python 2

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy mentioned this issue Mar 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@techalchemy techalchemy

Labels
bug Something isn't working in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@techalchemy