Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spinner should not exit after failure #96

Closed
techalchemy opened this issue Jun 3, 2019 · 0 comments · Fixed by #97
Closed

Spinner should not exit after failure #96

techalchemy opened this issue Jun 3, 2019 · 0 comments · Fixed by #97
Assignees
@techalchemy
Labels
bug Something isn't working

Comments

@techalchemy
Copy link
Member

The signal handler in the spinner is causing a deadlock on windows due to attempting to prematurely exit at runtime. We don't even actually want to exit here, so we should just stop trying.
@techalchemy techalchemy added the bug Something isn't working label Jun 3, 2019
@techalchemy techalchemy self-assigned this Jun 3, 2019
techalchemy added a commit that referenced this issue Jun 3, 2019
@techalchemy
Fix deadlock / race conditions on windows
759d8b7 
- Fix deadlock when fielding `CTRL_BREAK_EVENT` while spinner is running
- Fix failure to raise handled exceptions in `vistir.misc.run`
- Fixes #95
- Fixes #96

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy mentioned this issue Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@techalchemy techalchemy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deadlock / race conditions on windows sarugaku/vistir
1 participant
@techalchemy