Provide a way to capture or wrap streams #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also fix a bug with error reporting during `_create_subprocess` failures - Adds a stream wrapper using `TextIOWrapper` via `vistir.misc.StreamWrapper` - Adds `vistir.misc.get_wrapped_stream()` function to wrap existing streams - Adds `vistir.contextmanagers.replaced_stream()` to temporarily replace a stream - Fixes #49 - Closes #48 Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co> Add some extra compat utils Signed-off-by: Dan Ryan <dan@danryan.co> Add setup.cfg changes Signed-off-by: Dan Ryan <dan@danryan.co> uh, and init... Signed-off-by: Dan Ryan <dan@danryan.co> add fixture Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy
force-pushed
the
feature/48
branch
from
45081b9
to
e92fea4
Compare
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_create_subprocessfailures
TextIOWrapperviavistir.misc.StreamWrappervistir.misc.get_wrapped_stream()function to wrap existingstreams
vistir.contextmanagers.replaced_stream()to temporarily replacea stream
_create_subprocessfailures doesn't intersperse strings properly #49Signed-off-by: Dan Ryan dan@danryan.co