Fix Document Collapse #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored EncodeError created by the polorize function, it now returns a bare error that is wrapped into an EncodeError by Polorize. This is for uniformity with the Depolorize flow where all errors from depolorize are wrapped by it into DecodeError - Refactored Depolorize error for non pointer objects to be wrapped in a DecodeError. Update the relevant test case
- Fixed a bug with Document.Bytes() that caused it return pack encoded bytes instead of doc encoded bytes. #7 - Updated test case for the Bytes() method to be accurate.
Removed examples_test.go file and moved the testable example functions into polo_test.go and document_test.go
sarvalabs-manish
requested review from
sarvalabs-rahul
and removed request for
sarvalabs-rahul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document.Bytes()method to correctly encodeDocumentdataEncodeErrorgeneration to be done byPolorizeinstead of thepolorizefunction.Depolorizefunction returning an error for non pointer objects to be wrapped byDecodeError