Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: named databases #27

Closed
blitzmann opened this issue Feb 4, 2014 · 5 comments
Closed

Feature: named databases #27

blitzmann opened this issue Feb 4, 2014 · 5 comments

Comments

@blitzmann
Copy link
Contributor

Would be nice if we could name the databases from the config file. I'll take a whack at this today if I have time.

@sasanrose
Copy link
Owner

That is a great idea, but please bear in mind to make it optional

@blitzmann
Copy link
Contributor Author

So, you pulled this with pull request #28 along with the regex fix, literally seconds after I committed it to my repo. =)

I thought pull requests only pull the commits I tell it to, not the whole branch. Oh well.

It is optional, and works great for me. Let me know =)

@sasanrose
Copy link
Owner

Damn, The second I clicked on merge it was just one file changed. Anyway, I believe this throws a warning in PHP if $this->app->config['database']['names'][$i] is not set. Therefore, it may be better to check it before assigning.

@blitzmann
Copy link
Contributor Author

I forgot to change the logging level in config.

I'm always bad with remembering to check the array first. Will fix.

EDIT: #29

@sasanrose
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants