Fixed issue where tags at the beginning of summary not parsed correctly. #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If tags appeared before the category when parsing, the tags would not be added to the list of tags in the commit message. This was due, in part, to a regular expression that did not consider the possibility that the tag could be at the beginning of a line, and partially due to the fact that tags were only parsed from the remainder of the line AFTER categories had been removed. Fixes saschagrunert#928.
|
@saschagrunert I think perhaps I added the third test repository incorrectly. I'm not super familiar with git submodules. Could you advise on how I should add the necessary data to test this particular case? |
Hm, we could also add the whole test repository to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If tags appeared before the category when parsing, the tags would not be
added to the list of tags in the commit message. This was due, in part, to
a regular expression that did not consider the possibility that the tag
could be at the beginning of a line, and partially due to the fact that
tags were only parsed from the remainder of the line AFTER categories had
been removed.
Fixes #928.