Fix broken links by removing module name from github links #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 81.16% 81.31% +0.14%
==========================================
Files 1 1
Lines 154 182 +28
==========================================
+ Hits 125 148 +23
- Misses 20 24 +4
- Partials 9 10 +1 |
willie-yao
changed the title
willie-yao
force-pushed
the
fix-broken-links
branch
from
94be43b
to
6c09cf4
Compare
willie-yao
force-pushed
the
fix-broken-links
branch
from
97cce0f
to
1dfaeb3
Compare
willie-yao
changed the title
willie-yao
force-pushed
the
fix-broken-links
branch
from
1dfaeb3
to
e702c70
Compare
|
Hi @saschagrunert! We are running into an issue with some of the links generated from this tool. Let me know if it's okay for this fix to be included in the tool! |
willie-yao
force-pushed
the
fix-broken-links
branch
from
e702c70
to
c9642ab
Compare
willie-yao
force-pushed
the
fix-broken-links
branch
from
c9642ab
to
25be389
Compare
willie-yao
commented
Feb 1, 2024
| @@ -12,7 +12,6 @@ linters: | |||
| - containedctx | |||
| - contextcheck | |||
| - decorder | |||
| - depguard | |||
There was a problem hiding this comment.
Not sure what's up with depguard, but I had to update golangci for go 1.21 and it marked every import as not allowed.
willie-yao
commented
Feb 1, 2024
| @@ -9,7 +9,7 @@ stdenv: &stdenv | |||
| executors: | |||
| container: | |||
| docker: | |||
| - image: cimg/go:1.20 | |||
| - image: cimg/go:1.21 | |||
There was a problem hiding this comment.
Updating to go 1.21 so I can use the slices package.
This was referenced Feb 2, 2024
cpanato
reviewed
Feb 3, 2024
| @@ -12,7 +12,6 @@ linters: | |||
| - containedctx | |||
| - contextcheck | |||
| - decorder | |||
| - depguard | |||
| @@ -89,6 +88,7 @@ linters: | |||
| - whitespace | |||
| - wrapcheck | |||
| # - cyclop | |||
| # - depguard | |||
|
Created v1.3.4 for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with some of the links generated using the
-lflag. Some dependencies erroneously include the module name in the GitHub link. This PR adds some logic to trim the end of the link if it includes the module name.How to reproduce bug:
Notice how some links look like this
https://github.com/cespare/xxhash/v2/compare/v2.1.2...v2.2.0and lead to a 404 page when it should be thishttps://github.com/cespare/xxhash/compare/v2.1.2...v2.2.0.