Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rkyv feature for zero-copy deserialization #103

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

erictapen
Copy link

Hi, thanks for this great crate.

I was dissatisfied with the deserialization performance of the deser feature (using serde and bincode) and looked into zero-copy alternatives. Using rkyv I managed to read my Arena with ~17m nodes from disk in 3s (compared to 3min 30s before with serde).

This is a draft because I had to make a few types public, for it to compile. I would try to resolve that if you are generally interested in such a feature?

@saschagrunert
Copy link
Owner

@erictapen sounds good to me, it will be jus an optional feature.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Merging #103 (80734a9) into main (3576901) will increase coverage by 5.0%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #103     +/-   ##
=======================================
+ Coverage   60.9%   66.0%   +5.0%     
=======================================
  Files          8       8             
  Lines        474     474             
  Branches     170     145     -25     
=======================================
+ Hits         289     313     +24     
  Misses        42      42             
+ Partials     143     119     -24     

@erictapen
Copy link
Author

Blocked by rkyv/rkyv#275 for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants