Make rayon optional #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschagrunert
requested changes
Jul 8, 2018
| @@ -85,6 +87,7 @@ fn arenatree_iter() { | |||
| assert_eq!(node_refs, vec![&arena[a], &arena[b], &arena[c], &arena[d]]); | |||
| } | |||
|
|
|||
| #[cfg(feature = "par_iter")] | |||
There was a problem hiding this comment.
Can you please change the appveyor and travis config to also test with this feature?
src/lib.rs
Outdated
| arena | ||
| .nodes | ||
| .get_pair_mut(self.index, new_sibling.index, "Can not insert a node before itself"); | ||
| let (self_borrow, new_sibling_borrow) = arena.nodes.get_pair_mut( |
There was a problem hiding this comment.
I think the formatting is okay, I just formatted it with 120 chars per line in my rustfmt config.
| @@ -17,8 +17,13 @@ appveyor = { repository = "saschagrunert/indextree", branch = "master", service | |||
|
|
|||
| [features] | |||
| deser = [ "serde", "serde_derive" ] | |||
| par_iter = ["rayon"] | |||
There was a problem hiding this comment.
Can you please add a build including this feature in the appveyor and travis config?
|
Done. Removed the rustfmt commit and added the feature to the CI configs. |
saschagrunert
approved these changes
Jul 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
par_iterfeature and removedSyncbounds where they are not needed.I also formatted the code with rustfmt, but can remove the commit if you think this is unnecessary.