Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Eq for Arena and Node if the new 'derive-eq' feature is enabled #24

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Derive Eq for Arena and Node if the new 'derive-eq' feature is enabled #24

merged 1 commit into from
Apr 17, 2019

Conversation

phrohdoh
Copy link
Contributor

Closes #23

@saschagrunert
Copy link
Owner

LGTM, thanks!

@phrohdoh
Copy link
Contributor Author

I wasn't sure if/how you'd want the crate version bumped so I didn't touch it.

Please let me know if I can help get this published to crates.io as I'm working on something that has a dependency on this changeset.

@saschagrunert
Copy link
Owner

I wasn't sure if/how you'd want the crate version bumped so I didn't touch it.

Please let me know if I can help get this published to crates.io as I'm working on something that has a dependency on this changeset.

Sure, I will release a new version tomorrow.

@saschagrunert saschagrunert merged commit 38009cc into saschagrunert:master Apr 17, 2019
@phrohdoh phrohdoh deleted the impl-eq-for-arena-and-node branch April 17, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-impl Eq for Arena and Node when T: Eq
2 participants
@phrohdoh @saschagrunert