Split code into modules #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Import `serde::{Deserialize, Serialize}` explicitly.
* Use `derive` feature of `serde` crate.
lo48576
added a commit
to lo48576/indextree
that referenced
this pull request
Aug 1, 2019
This should be done in saschagrunert#33 but there was a mistake.
lo48576
added a commit
to lo48576/indextree
that referenced
this pull request
Aug 2, 2019
This should be done in saschagrunert#33 but there was a mistake.
lo48576
added a commit
to lo48576/indextree
that referenced
this pull request
Aug 2, 2019
This should be done in saschagrunert#33 but there was a mistake.
lo48576
added a commit
to lo48576/indextree
that referenced
this pull request
Aug 3, 2019
This should be done in saschagrunert#33 but overlooked.
Merged
saschagrunert
pushed a commit
that referenced
this pull request
Aug 3, 2019
* Apply rustfmt * Move impl for `Node<T>` into `node` module This should be done in #33 but overlooked. * Improve doc comments * Use third person singular present indicative form for method summary. * Reword and fix some comments. * Add links if typenames and methods are used in doc comments. See also: [rfc-0505]. [rfc-0505]: https://rust-lang.github.io/rfcs/0505-api-comment-conventions.html * Add examples sections to many methods They are not only simple usage guide, but also tests. * Add tests for insertion failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tiny refactoring.
Split code into modules
arena,error,id,node, andtraverse.This change may keep things simple and make it easy to find and change relevant code.
Types are exported from top-level, and modules itself are private.
So public items are not changed and this is non-breaking change.