Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a type parameter from NodeEdge type #40

Merged
merged 1 commit into from
Aug 4, 2019
Merged

Remove a type parameter from NodeEdge type #40

merged 1 commit into from
Aug 4, 2019

Conversation

lo48576
Copy link
Contributor

@lo48576 lo48576 commented Aug 4, 2019

This is breaking change.

It is always used as NodeEdge<NodeId>.
No need of parametrizing.

@lo48576
Remove a type parameter from NodeEdge type
791248c 
It is always used as `NodeEdge<NodeId>`.
No need of parametrizing.
@lo48576 lo48576 mentioned this pull request Aug 4, 2019
Merged
saschagrunert
saschagrunert approved these changes Aug 4, 2019
View reviewed changes
Copy link
Owner

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too

@saschagrunert saschagrunert merged commit 520642e into saschagrunert:master Aug 4, 2019
@lo48576 lo48576 deleted the feature/monomorphize-node-edge branch August 4, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lo48576 @saschagrunert