Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress clippy lints by fixing the sources #80

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Suppress clippy lints by fixing the sources #80

merged 1 commit into from
Mar 7, 2022

Conversation

lo48576
Copy link
Contributor

@lo48576 lo48576 commented Mar 4, 2022

Clippy version is clippy 0.1.59 (9d1b210 2022-02-23).

@lo48576 lo48576 mentioned this pull request Mar 4, 2022
Merged
@lo48576
Copy link
Contributor Author

lo48576 commented Mar 4, 2022 •
edited
Loading

The CI failure seems false positive.
Codecov failure is "checksum" error (I don't know what it is), and the codebase itself doesn't seems to be responsible.

saschagrunert
saschagrunert approved these changes Mar 7, 2022
View reviewed changes
Copy link
Owner

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check the codecov issues, thank you for this fix!

@saschagrunert saschagrunert merged commit 709eb69 into saschagrunert:master Mar 7, 2022
@lo48576 lo48576 deleted the fix/clippy-lint branch September 22, 2022 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lo48576 @saschagrunert