Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Predecessors Iterator and minor doc fixes #91

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Add Predecessors Iterator and minor doc fixes #91

merged 1 commit into from
Jan 9, 2023

Conversation

b4D8
Copy link

@b4D8 b4D8 commented Jan 3, 2023

Hi @saschagrunert and thanks for your great work on this crate!

I submit the attached contribution which contains 3 modifications:

  • a convenience Iterator over Predecessors (including ancestors and previous siblings)
  • a fix for a typo (missing "of") in Ancestor's documentation (line 22 of src/traverse.rs)
  • some visual indices in Iterators' documentation which IMHO help legibility

Hope you'll find those useful.
And sorry I forgot to do multiple commits... feel free to discard what is unwanted

Cheers!

@b4D8 b4D8 changed the title Add Predecessor Iterator and minor doc fixes Add Predecessors Iterator and minor doc fixes Jan 3, 2023
Copy link
Owner

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for the contribution!

@saschagrunert saschagrunert merged commit 303f900 into saschagrunert:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants